Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve the help tips for system setting options #5516

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 17, 2024

What type of PR is this?

/area core
/kind improvement
/milestone 2.14.0

What this PR does / why we need it:

improve the help tips for system setting options

image

Which issue(s) this PR fixes:

Fixes #5513

Does this PR introduce a user-facing change?

完善系统设置选项的帮助提示。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 17, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.0 milestone Mar 17, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang March 17, 2024 13:12
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Mar 17, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from minliacom March 17, 2024 13:12
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.56%. Comparing base (5fdf6c0) to head (f4b42a2).
Report is 63 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5516      +/-   ##
============================================
- Coverage     56.91%   56.56%   -0.35%     
+ Complexity     3319     3310       -9     
============================================
  Files           587      592       +5     
  Lines         18968    19178     +210     
  Branches       1401     1355      -46     
============================================
+ Hits          10795    10848      +53     
- Misses         7594     7769     +175     
+ Partials        579      561      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LIlGG
Copy link
Member

LIlGG commented Mar 18, 2024

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2024
Copy link

f2c-ci-robot bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit bf81f29 into halo-dev:main Mar 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

希望为系统设置中的部分选项提供用途描述
3 participants