-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add image editor feature for attachment upload component #5585
feat: add image editor feature for attachment upload component #5585
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5585 +/- ##
============================================
- Coverage 56.91% 56.54% -0.38%
+ Complexity 3319 3313 -6
============================================
Files 587 592 +5
Lines 18968 19204 +236
Branches 1401 1355 -46
============================================
+ Hits 10795 10858 +63
- Misses 7594 7784 +190
+ Partials 579 562 -17 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing work🔥
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area ui
/kind feature
/milestone 2.14.x
What this PR does / why we need it:
为上传附件的组件添加基本的图片编辑功能。
Which issue(s) this PR fixes:
Fixes #5583
Does this PR introduce a user-facing change?