Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add image editor feature for attachment upload component #5585

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 25, 2024

What type of PR is this?

/area ui
/kind feature
/milestone 2.14.x

What this PR does / why we need it:

为上传附件的组件添加基本的图片编辑功能。

image

Which issue(s) this PR fixes:

Fixes #5583

Does this PR introduce a user-facing change?

为上传附件的组件添加基本的图片编辑功能。

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 25, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.x milestone Mar 25, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 25, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from QuentinHsu and wan92hen March 25, 2024 03:41
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.54%. Comparing base (5fdf6c0) to head (764b143).
Report is 78 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5585      +/-   ##
============================================
- Coverage     56.91%   56.54%   -0.38%     
+ Complexity     3319     3313       -6     
============================================
  Files           587      592       +5     
  Lines         18968    19204     +236     
  Branches       1401     1355      -46     
============================================
+ Hits          10795    10858      +63     
- Misses         7594     7784     +190     
+ Partials        579      562      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work🔥

Copy link

f2c-ci-robot bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 2af9239 into halo-dev:main Mar 25, 2024
8 checks passed
@ruibaby ruibaby deleted the feat/attachment-image-editor branch March 25, 2024 04:16
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望附件上传支持图片编辑
3 participants