Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: post tag management page #5593

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Mar 26, 2024

What type of PR is this?

/kind improvement
/area ui

What this PR does / why we need it:

使用分页列表的形式重新展示文章标签页,移除原有的 grid 形式。

How to test it?

查看文章标签页面的分页列表功能显示是否正常。
完成增、删、改之后是否能够正常回显。

Which issue(s) this PR fixes:

Fixes #5415

Does this PR introduce a user-facing change?

使用分页列表的形式重构文章标签页 UI

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 26, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from Aanko March 26, 2024 07:13
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Mar 26, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wzrove March 26, 2024 07:13
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.48%. Comparing base (5fdf6c0) to head (1706238).
Report is 98 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5593      +/-   ##
============================================
- Coverage     56.91%   56.48%   -0.43%     
- Complexity     3319     3320       +1     
============================================
  Files           587      595       +8     
  Lines         18968    19250     +282     
  Branches       1401     1357      -44     
============================================
+ Hits          10795    10874      +79     
- Misses         7594     7814     +220     
+ Partials        579      562      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LIlGG LIlGG added this to the 2.14.x milestone Mar 26, 2024
@ruibaby ruibaby changed the title refactor: display post tags in the form of a paginated list refactor: post tag management page Mar 29, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当前界面改动没有问题,但目前缺失搜索,筛选,排序等功能,如果决定发布到 2.14.x,可能需要再提交 PR 完善。

image

ui/src/locales/zh-CN.yaml Outdated Show resolved Hide resolved
ui/src/locales/zh-TW.yaml Outdated Show resolved Hide resolved
ui/src/locales/en.yaml Outdated Show resolved Hide resolved
@ruibaby ruibaby modified the milestones: 2.14.x, 2.15.x Apr 1, 2024
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@LIlGG
Copy link
Member Author

LIlGG commented Apr 8, 2024

当前界面改动没有问题,但目前缺失搜索,筛选,排序等功能,如果决定发布到 2.14.x,可能需要再提交 PR 完善。

是否需要在当前 PR 下继续完成搜索、筛选、排序功能?

@ruibaby
Copy link
Member

ruibaby commented Apr 11, 2024

当前界面改动没有问题,但目前缺失搜索,筛选,排序等功能,如果决定发布到 2.14.x,可能需要再提交 PR 完善。

是否需要在当前 PR 下继续完成搜索、筛选、排序功能?

先合并。

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 26db603 into halo-dev:main Apr 11, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.15.x, 2.15.0 Apr 11, 2024
@LIlGG LIlGG deleted the refactor/tag-list branch April 15, 2024 07:03
f2c-ci-robot bot pushed a commit that referenced this pull request Apr 28, 2024
#### What type of PR is this?

/kind bug
/area ui

#### What this PR does / why we need it:

补充 #5593 中缺少的 `api.console.halo.run` 权限。用于解决具有文章列表权限的用户,访问标签列表时提示无权限的问题

#### How to test it?

创建一个具有文章列表查看权限的用户,是否能够访问到标签列表。

#### Which issue(s) this PR fixes:

Fixes #5814

#### Does this PR introduce a user-facing change?
```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

批量删除TAGS
3 participants