-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: selecting the previous post leads to a negative page #5594
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch man
/lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5594 +/- ##
============================================
- Coverage 56.91% 56.49% -0.43%
- Complexity 3319 3320 +1
============================================
Files 587 595 +8
Lines 18968 19249 +281
Branches 1401 1357 -44
============================================
+ Hits 10795 10874 +79
- Misses 7594 7813 +219
+ Partials 579 562 -17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area ui
What this PR does / why we need it:
修复当选中首个文章设置时,点击上一个还可以继续修改
page
的问题。How to test it?
测试选中首个文章设置之后,点击上一个是否不再修改
page
值Which issue(s) this PR fixes:
Fixes #5475
Does this PR introduce a user-facing change?