-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support sorting posts by views and comment count #5614
Conversation
application/src/main/java/run/halo/app/extension/index/IndexBuilderImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: ZJamss <zjamss@qq.com>
Signed-off-by: ZJamss <zjamss@qq.com>
Signed-off-by: ZJamss <zjamss@qq.com>
application/src/main/java/run/halo/app/core/extension/reconciler/PostCounterReconciler.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/core/extension/reconciler/PostCounterReconciler.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/core/extension/reconciler/PostCounterReconciler.java
Outdated
Show resolved
Hide resolved
api/src/main/java/run/halo/app/core/extension/content/Post.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/event/post/PostChangeEvent.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/core/extension/reconciler/PostCounterReconciler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: ZJamss <zjamss@qq.com>
Signed-off-by: ZJamss <zjamss@qq.com>
Hi @ZJamss , 我这提供一个实现思路你参考一下吧 main...guqing:halo:feature/sortby-visits |
好的,再次感谢,那我也是继续重构代码重新提交commit to review吗 |
是的,由于此 issue 是你在解决,所以你继续提交即可, 我给出的解决方式只是参考 |
Signed-off-by: ZJamss <zjamss@qq.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5614 +/- ##
============================================
- Coverage 56.91% 56.49% -0.42%
- Complexity 3319 3332 +13
============================================
Files 587 598 +11
Lines 18968 19325 +357
Branches 1401 1359 -42
============================================
+ Hits 10795 10918 +123
- Misses 7594 7843 +249
+ Partials 579 564 -15 ☔ View full report in Codecov by Sentry. |
Hello,@guqing,请问有时间review一下吗,我好像不能re-request review了 |
api/src/main/java/run/halo/app/extension/controller/ControllerBuilder.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/core/extension/reconciler/PostCounterReconciler.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/event/post/PostStatsChangedEvent.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/infra/SchemeInitializer.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/metrics/PostStatsUpdater.java
Outdated
Show resolved
Hide resolved
Hi @ZJamss 感谢你的付出,等解决之后,请等待我们测试之后的反馈,如果没有问题将会进入合并流程 |
Signed-off-by: ZJamss <zjamss@qq.com>
api/src/main/java/run/halo/app/extension/controller/ControllerBuilder.java
Outdated
Show resolved
Hide resolved
/milestone 2.15.x |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works very well!
Thanks for your first contribution!
/approve
/ping @halo-dev/sig-halo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Congrats on merging your pull request! 🎉🎉🎉 Thank you for your efforts
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🎉🎉🎉 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
文章支持根据访问量和评论量排序
Which issue(s) this PR fixes:
Fixes #3216
Does this PR introduce a user-facing change?