-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add line-height setting feature for the default editor #5681
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5681 +/- ##
============================================
- Coverage 56.91% 56.58% -0.34%
- Complexity 3319 3324 +5
============================================
Files 587 595 +8
Lines 18968 19243 +275
Branches 1401 1357 -44
============================================
+ Hits 10795 10888 +93
- Misses 7594 7793 +199
+ Partials 579 562 -17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area editor
/milestone 2.15.x
What this PR does / why we need it:
此 PR 为默认富文本编辑器中的 P 标签设置了
line-height
属性,因此可以支持为某一行设置行高。How to test it?
测试行高功能是否正常。测试在不同组件下功能是否正常。
Which issue(s) this PR fixes:
Fixes #5660
Does this PR introduce a user-facing change?