Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add line-height setting feature for the default editor #5681

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Apr 10, 2024

What type of PR is this?

/kind feature
/area editor
/milestone 2.15.x

What this PR does / why we need it:

此 PR 为默认富文本编辑器中的 P 标签设置了 line-height 属性,因此可以支持为某一行设置行高。

How to test it?

测试行高功能是否正常。测试在不同组件下功能是否正常。

Which issue(s) this PR fixes:

Fixes #5660

Does this PR introduce a user-facing change?

为默认富文本编辑器增加行高设置

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 10, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.15.x milestone Apr 10, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and lan-yonghui April 10, 2024 07:32
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Apr 10, 2024
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.58%. Comparing base (5fdf6c0) to head (e6e2134).
Report is 99 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5681      +/-   ##
============================================
- Coverage     56.91%   56.58%   -0.34%     
- Complexity     3319     3324       +5     
============================================
  Files           587      595       +8     
  Lines         18968    19243     +275     
  Branches       1401     1357      -44     
============================================
+ Hits          10795    10888      +93     
- Misses         7594     7793     +199     
+ Partials        579      562      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby ruibaby changed the title feat: add line height settings to the default rich text editor feat: add line-height setting feature for the default rich text editor Apr 10, 2024
@ruibaby ruibaby changed the title feat: add line-height setting feature for the default rich text editor feat: add line-height setting feature for the default editor Apr 10, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

/lgtm

Incredible work!

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit fc79de7 into halo-dev:main Apr 11, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.15.x, 2.15.0 Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

默认编辑器支持行高设置
3 participants