Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code block content insertion location error #5737

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Apr 18, 2024

What type of PR is this?

/kind bug
/area editor
/milestone 2.15.x

What this PR does / why we need it:

在编写多行文本后,粘贴代码块时,会出现粘贴的内容插入错误,其与代码块分割开。

2024-04-10.140202_out.mp4

在本 PR 中,在创建 CodeBlock 时,将 Text 转为 TextNode 后,一同传入作为 CodeBlock 的 content。
另外为了保证插入代码块之后,光标处于代码块中,将会从插入位置的 from 开始往文档顶部搜索。

How to test it?

测试示例中的场景下,代码块插入是否正常。

测试在代码块前后放入其他代码块或者其他块,插入代码块后光标是否在代码块中。

Which issue(s) this PR fixes:

Fixes #5736

Does this PR introduce a user-facing change?

修复默认编辑器中粘贴代码块会出现错行的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 18, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.15.x milestone Apr 18, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Apr 18, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and guqing April 18, 2024 04:26
Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.48%. Comparing base (5fdf6c0) to head (b9a361b).
Report is 114 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5737      +/-   ##
============================================
- Coverage     56.91%   56.48%   -0.44%     
- Complexity     3319     3333      +14     
============================================
  Files           587      598      +11     
  Lines         18968    19334     +366     
  Branches       1401     1359      -42     
============================================
+ Hits          10795    10920     +125     
- Misses         7594     7849     +255     
+ Partials        579      565      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
Copy link

f2c-ci-robot bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit fdc2453 into halo-dev:main Apr 18, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.15.x, 2.15.0 Apr 18, 2024
@ruibaby
Copy link
Member

ruibaby commented Apr 23, 2024

/cherry-pick release-2.14

@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #5773

In response to this:

/cherry-pick release-2.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

粘贴代码块的时候代码块格式丢失
3 participants