-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: code block content insertion location error #5737
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5737 +/- ##
============================================
- Coverage 56.91% 56.48% -0.44%
- Complexity 3319 3333 +14
============================================
Files 587 598 +11
Lines 18968 19334 +366
Branches 1401 1359 -42
============================================
+ Hits 10795 10920 +125
- Misses 7594 7849 +255
+ Partials 579 565 -14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-2.14 |
@ruibaby: new pull request created: #5773 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/area editor
/milestone 2.15.x
What this PR does / why we need it:
在编写多行文本后,粘贴代码块时,会出现粘贴的内容插入错误,其与代码块分割开。
2024-04-10.140202_out.mp4
在本 PR 中,在创建 CodeBlock 时,将 Text 转为
TextNode
后,一同传入作为CodeBlock
的 content。另外为了保证插入代码块之后,光标处于代码块中,将会从插入位置的 from 开始往文档顶部搜索。
How to test it?
测试示例中的场景下,代码块插入是否正常。
测试在代码块前后放入其他代码块或者其他块,插入代码块后光标是否在代码块中。
Which issue(s) this PR fixes:
Fixes #5736
Does this PR introduce a user-facing change?