Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add original password verification for password change #5748

Merged
merged 10 commits into from
Apr 21, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Apr 19, 2024

What type of PR is this?

/kind feature
/area core
/milestone 2.15.x

What this PR does / why we need it:

用户修改密码功能增加原始密码确认步骤

Which issue(s) this PR fixes:

Fixes #2427

Does this PR introduce a user-facing change?

用户修改密码功能增加原始密码确认步骤

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 19, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.15.x milestone Apr 19, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Apr 19, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby April 19, 2024 09:38
@guqing guqing force-pushed the fix/user-password branch from 9249356 to a09311a Compare April 19, 2024 09:43
Signed-off-by: Ryan Wang <i@ryanc.cc>
@guqing guqing force-pushed the fix/user-password branch from cd83bf9 to 9159dc6 Compare April 19, 2024 09:52
@guqing guqing force-pushed the fix/user-password branch from 9159dc6 to 817b9e2 Compare April 19, 2024 09:53
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 86.84211% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 56.53%. Comparing base (5fdf6c0) to head (267701d).
Report is 122 commits behind head on main.

Files Patch % Lines
...lo/app/core/extension/service/UserServiceImpl.java 50.00% 3 Missing and 1 partial ⚠️
...halo/app/core/extension/endpoint/UserEndpoint.java 96.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5748      +/-   ##
============================================
- Coverage     56.91%   56.53%   -0.39%     
- Complexity     3319     3339      +20     
============================================
  Files           587      598      +11     
  Lines         18968    19630     +662     
  Branches       1401     1360      -41     
============================================
+ Hits          10795    11097     +302     
- Misses         7594     7966     +372     
+ Partials        579      567      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing force-pushed the fix/user-password branch from ef9096a to 267701d Compare April 19, 2024 11:10
@wan92hen
Copy link
Collaborator

修改密码后能否把当前 session 都清理掉,强制用户重新登录呢。

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

实际测试符合预期。

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2024
@ruibaby
Copy link
Member

ruibaby commented Apr 20, 2024

修改密码后能否把当前 session 都清理掉,强制用户重新登录呢。

我将单独提交一个 issue。

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
It works very well.

api-docs/openapi/v3_0/aggregated.json Show resolved Hide resolved
Copy link

f2c-ci-robot bot commented Apr 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2024
@JohnNiang
Copy link
Member

修改密码后能否把当前 session 都清理掉,强制用户重新登录呢。

修改密码清理当前 Session 意义不大,应该清理掉当前用户所有的 Session。

@ruibaby ruibaby closed this Apr 21, 2024
@ruibaby ruibaby reopened this Apr 21, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@JohnNiang JohnNiang merged commit f07c09b into halo-dev:main Apr 21, 2024
12 of 13 checks passed
@guqing guqing deleted the fix/user-password branch April 22, 2024 02:41
@ruibaby ruibaby modified the milestones: 2.15.x, 2.15.0 Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

用户密码重置逻辑异常
4 participants