-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add original password verification for password change #5748
Conversation
9249356
to
a09311a
Compare
cd83bf9
to
9159dc6
Compare
9159dc6
to
817b9e2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5748 +/- ##
============================================
- Coverage 56.91% 56.53% -0.39%
- Complexity 3319 3339 +20
============================================
Files 587 598 +11
Lines 18968 19630 +662
Branches 1401 1360 -41
============================================
+ Hits 10795 11097 +302
- Misses 7594 7966 +372
+ Partials 579 567 -12 ☔ View full report in Codecov by Sentry. |
ef9096a
to
267701d
Compare
修改密码后能否把当前 session 都清理掉,强制用户重新登录呢。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
实际测试符合预期。
我将单独提交一个 issue。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
It works very well.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
修改密码清理当前 Session 意义不大,应该清理掉当前用户所有的 Session。 |
Quality Gate passedIssues Measures |
What type of PR is this?
/kind feature
/area core
/milestone 2.15.x
What this PR does / why we need it:
用户修改密码功能增加原始密码确认步骤
Which issue(s) this PR fixes:
Fixes #2427
Does this PR introduce a user-facing change?