Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: invalidate all sessions of a user after password changed #5757

Merged
merged 8 commits into from
Apr 23, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Apr 21, 2024

What type of PR is this?

/kind feature
/area core
/milestone 2.15.x

What this PR does / why we need it:

新增修改用户密码之后踢除用户的所有登陆会话的功能

Which issue(s) this PR fixes:

Fixes #5753

Does this PR introduce a user-facing change?

新增修改用户密码之后踢除用户的所有登陆会话的功能

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 21, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.15.x milestone Apr 21, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Apr 21, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and ruibaby April 21, 2024 10:08
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 80.51948% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 56.41%. Comparing base (5fdf6c0) to head (ccddff9).
Report is 130 commits behind head on main.

❗ Current head ccddff9 differs from pull request most recent head c9d72a7. Consider uploading reports for the commit c9d72a7 to get more accurate results

Files Patch % Lines
.../security/session/SessionInvalidationListener.java 9.09% 10 Missing ⚠️
...sion/InMemoryReactiveIndexedSessionRepository.java 92.45% 2 Missing and 2 partials ⚠️
.../run/halo/app/event/user/PasswordChangedEvent.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5757      +/-   ##
============================================
- Coverage     56.91%   56.41%   -0.50%     
- Complexity     3319     3347      +28     
============================================
  Files           587      603      +16     
  Lines         18968    19704     +736     
  Branches       1401     1357      -44     
============================================
+ Hits          10795    11116     +321     
- Misses         7594     8025     +431     
+ Partials        579      563      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing
Copy link
Member Author

guqing commented Apr 22, 2024

/hold

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
@guqing
Copy link
Member Author

guqing commented Apr 22, 2024

/unhold

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
@guqing
Copy link
Member Author

guqing commented Apr 22, 2024

/hold

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@ruibaby ruibaby merged commit 06e0b63 into halo-dev:main Apr 23, 2024
7 of 8 checks passed
@guqing guqing deleted the feature/5753 branch April 23, 2024 08:09
@guqing guqing removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
@ruibaby ruibaby modified the milestones: 2.15.x, 2.15.0 Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望在用户密码修改之后能够移除活跃的登录 Session
4 participants