Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toast the http request error #5796

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Apr 25, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.15.x

What this PR does / why we need it:

优化 Console 的请求异常提示,如果异常不满足原有的判断逻辑,最终将提示 status + statusText,不再显示未知错误,方便使用者根据异常提示进行排查。

image

Which issue(s) this PR fixes:

Fixes #5739

Special notes for your reviewer:

我的测试方式:

使用 Caddy 模拟请求异常:

:9000

encode gzip

@blocked {
   path /apis/content.halo.run/v1alpha1/posts/**
}

respond @blocked 413

reverse_proxy 127.0.0.1:8090

Does this PR introduce a user-facing change?

优化 Console 的请求异常提示,方便异常排查。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 25, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.15.x milestone Apr 25, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Apr 25, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG April 25, 2024 04:01
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.47%. Comparing base (5fdf6c0) to head (bbb89a9).
Report is 135 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5796      +/-   ##
============================================
- Coverage     56.91%   56.47%   -0.44%     
- Complexity     3319     3357      +38     
============================================
  Files           587      604      +17     
  Lines         18968    19790     +822     
  Branches       1401     1362      -39     
============================================
+ Hits          10795    11177     +382     
- Misses         7594     8046     +452     
+ Partials        579      567      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 924aad1 into halo-dev:main Apr 25, 2024
8 checks passed
@ruibaby ruibaby deleted the feat/catch-request-error branch April 25, 2024 08:14
@ruibaby ruibaby modified the milestones: 2.15.x, 2.15.0 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望支持提示来自反向代理的请求异常
3 participants