-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: toast the http request error #5796
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5796 +/- ##
============================================
- Coverage 56.91% 56.47% -0.44%
- Complexity 3319 3357 +38
============================================
Files 587 604 +17
Lines 18968 19790 +822
Branches 1401 1362 -39
============================================
+ Hits 10795 11177 +382
- Misses 7594 8046 +452
+ Partials 579 567 -12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/area ui
/kind improvement
/milestone 2.15.x
What this PR does / why we need it:
优化 Console 的请求异常提示,如果异常不满足原有的判断逻辑,最终将提示 status + statusText,不再显示未知错误,方便使用者根据异常提示进行排查。
Which issue(s) this PR fixes:
Fixes #5739
Special notes for your reviewer:
我的测试方式:
使用 Caddy 模拟请求异常:
Does this PR introduce a user-facing change?