-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the problem that bundle files can be generated arbitrarily #6028
Fix the problem that bundle files can be generated arbitrarily #6028
Conversation
Signed-off-by: JohnNiang <johnniang@foxmail.com>
@JohnNiang: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6028 +/- ##
============================================
- Coverage 56.91% 56.47% -0.44%
- Complexity 3319 3541 +222
============================================
Files 587 622 +35
Lines 18968 20961 +1993
Branches 1401 1478 +77
============================================
+ Hits 10795 11838 +1043
- Misses 7594 8523 +929
- Partials 579 600 +21 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#6073) #### What type of PR is this? /kind regression /area plugin /milestone 2.17.x #### What this PR does / why we need it: This PR reverts changes of generating bundle resource version in <#6028>. Because the changes were adapted realtime change of bundle files for plugin developers in plugin development runtime mode, but I ignored it. #### Special notes for your reviewer: 1. Try to start Halo in plugin development mode 2. Change and rebuild ui resources 3. Refresh console and check the result #### Does this PR introduce a user-facing change? ```release-note None ```
What type of PR is this?
/kind bug
/area core
/area plugin
/milestone 2.16.0
What this PR does / why we need it:
Before the PR, any user can generate bundle files by providing random query param
v
while requesting bundle files.This PR refactors the whole bundle file generation method.
Special notes for your reviewer:
http://localhost:8090/apis/api.console.halo.run/v1alpha1/plugins/-/bundle.js?v=xyz
xyz.js
in folder$TMPDIR/halo-plugin-bundle**
Does this PR introduce a user-facing change?