Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem of not being able to rebuild search index #6323

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.18.x

What this PR does / why we need it:

This PR fixes the problem of not being able to rebuild search index due to null description and updateTimestamp.

Which issue(s) this PR fixes:

Fixes #6317

Does this PR introduce a user-facing change?

修复无法正常刷新搜索引擎的问题

Signed-off-by: JohnNiang <johnniang@foxmail.com>
@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 15, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 15, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jul 15, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen July 15, 2024 03:15
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.31%. Comparing base (bc10336) to head (5f4084b).
Report is 74 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6323      +/-   ##
============================================
+ Coverage     54.51%   58.31%   +3.80%     
- Complexity     3523     3763     +240     
============================================
  Files           646      646              
  Lines         21862    21975     +113     
  Branches       1528     1545      +17     
============================================
+ Hits          11917    12814     +897     
+ Misses         9328     8543     -785     
- Partials        617      618       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024
@ruibaby
Copy link
Member

ruibaby commented Jul 15, 2024

/cherrypick release-2.17

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.17 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 6bc1355 into halo-dev:main Jul 15, 2024
7 checks passed
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #6324

In response to this:

/cherrypick release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang JohnNiang deleted the bug/lucene-search branch July 15, 2024 03:45
f2c-ci-robot bot pushed a commit that referenced this pull request Jul 15, 2024
…dex (#6324)

This is an automated cherry-pick of #6323

/assign ruibaby

```release-note
修复无法正常刷新搜索引擎的问题
```
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

创建搜索引擎索引失败
3 participants