Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump tiptap version to 2.5.1 #6327

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jul 15, 2024

What type of PR is this?

/area ui
/area editor
/kind improvement
/milestone 2.18.x

What this PR does / why we need it:

升级 Tiptap 相关依赖至 2.5.1

Does this PR introduce a user-facing change?

升级 Tiptap 相关依赖至 [2.5.1](https://tiptap.dev/blog/release-notes/say-hello-to-tiptap-2-5-our-most-performant-editor-yet)

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Jul 15, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 15, 2024
@f2c-ci-robot f2c-ci-robot bot added area/editor Issues or PRs related to the Editor kind/improvement Categorizes issue or PR as related to a improvement. labels Jul 15, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen July 15, 2024 07:07
@JohnNiang
Copy link
Member

Hi @ruibaby, please resolve the failing test.

Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.27%. Comparing base (bc10336) to head (8ec0b64).
Report is 77 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6327      +/-   ##
============================================
+ Coverage     54.51%   58.27%   +3.76%     
- Complexity     3523     3761     +238     
============================================
  Files           646      646              
  Lines         21862    21975     +113     
  Branches       1528     1545      +17     
============================================
+ Hits          11917    12806     +889     
+ Misses         9328     8550     -778     
- Partials        617      619       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby ruibaby changed the title chore: bump tiptap version to 2.5.0 chore: bump tiptap version to 2.5.1 Jul 16, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
@LIlGG
Copy link
Member

LIlGG commented Jul 16, 2024

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 3c6df3b into halo-dev:main Jul 16, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 22, 2024
@ruibaby ruibaby deleted the chore/bump-tiptap-dependencies branch August 16, 2024 15:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants