Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: share ExtensionGetter Bean with plugins for extension retrieval #6365

Merged

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jul 24, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.18.x

What this PR does / why we need it:

通过将 ExtensionGetter Bean 共享到给插件的 ApplicationContext,插件能够方便地使用该 Bean 来获取扩展。此更改确保插件具有可靠的扩展访问方式,从而促进系统内更好的模块化和可扩展性。

Which issue(s) this PR fixes:

Fixes #6357

Does this PR introduce a user-facing change?

将 ExtensionGetter Bean 共享给插件使用,以便插件可以通过它来获取扩展

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 24, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 24, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jul 24, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby July 24, 2024 08:33
Copy link

sonarcloud bot commented Jul 24, 2024

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.35%. Comparing base (bc10336) to head (fb519c3).
Report is 82 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6365      +/-   ##
============================================
+ Coverage     54.51%   58.35%   +3.84%     
- Complexity     3523     3766     +243     
============================================
  Files           646      646              
  Lines         21862    21986     +124     
  Branches       1528     1546      +18     
============================================
+ Hits          11917    12829     +912     
+ Misses         9328     8535     -793     
- Partials        617      622       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 25, 2024
@guqing
Copy link
Member

guqing commented Jul 25, 2024

/retitle feat: share ExtensionGetter Bean with plugins for extension retrieval

@f2c-ci-robot f2c-ci-robot bot changed the title pref: ExtensionGetter bean for plugin expansion feat: share ExtensionGetter Bean with plugins for extension retrieval Jul 25, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2024
Copy link

f2c-ci-robot bot commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 1d3ba46 into halo-dev:main Jul 25, 2024
8 checks passed
@guqing
Copy link
Member

guqing commented Jul 25, 2024

@LIlGG 此 PR 需要增加开发者文档,以告知插件开发者如何使用 ExtensionGetter 来扩展自己的插件功能

@LIlGG LIlGG deleted the feat/open-to-plugin-extesiongetter branch July 25, 2024 03:03
@LIlGG
Copy link
Member Author

LIlGG commented Jul 25, 2024

@LIlGG 此 PR 需要增加开发者文档,以告知插件开发者如何使用 ExtensionGetter 来扩展自己的插件功能

好,我去补充一下相关文档。

f2c-ci-robot bot pushed a commit to halo-dev/docs that referenced this pull request Jul 26, 2024
#### What this PR does / why we need it:

添加 ExtensionGetter 的开发者文档及示例。

see halo-dev/halo#6365

#### Does this PR introduce a user-facing change?
```release-note
None
```
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 29, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

希望能够向插件提供 ExtensionGetter 扩展
3 participants