Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ApplicationContext inaccessible in ITemplateContext #6680

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Make ApplicationContext inaccessible in ITemplateContext #6680

merged 1 commit into from
Sep 20, 2024

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind improvement
/area core
/area plugin
/milestone 2.20.x

What this PR does / why we need it:

This PR disables access to ApplicationContext using ITemplateContext.

Does this PR introduce a user-facing change?

None

@JohnNiang
Make ApplicationContext inaccessible in ITemplateContext
849335e 
Signed-off-by: JohnNiang <johnniang@foxmail.com>
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Sep 19, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 19, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG September 19, 2024 08:29
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 19, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen September 19, 2024 08:29
@f2c-ci-robot f2c-ci-robot bot added the area/plugin Issues or PRs related to the Plugin Provider label Sep 19, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 28 lines in your changes missing coverage. Please review.

Project coverage is 58.04%. Comparing base (6cd8dc8) to head (849335e).
Report is 79 commits behind head on main.

Files with missing lines Patch % Lines
.../halo/app/theme/dialect/SecureTemplateContext.java 24.32% 25 Missing and 3 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6680      +/-   ##
============================================
- Coverage     58.18%   58.04%   -0.14%     
- Complexity     3774     3942     +168     
============================================
  Files           651      676      +25     
  Lines         22125    23154    +1029     
  Branches       1538     1579      +41     
============================================
+ Hits          12873    13440     +567     
- Misses         8641     9090     +449     
- Partials        611      624      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

guqing
guqing approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2024
@guqing
Copy link
Member

guqing commented Sep 20, 2024

/kind api-change
此 PR 禁止插件通过 SpringContextUtils 获取 ApplicationContext，如果插件使用到此方法则需要使用依赖注入来代替

@f2c-ci-robot f2c-ci-robot bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Sep 20, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit a87dedd into halo-dev:main Sep 20, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 20, 2024
@JohnNiang JohnNiang mentioned this pull request Oct 16, 2024
Closed
@JohnNiang JohnNiang deleted the refactor/customize-itemplatecontext-for-plugins branch October 16, 2024 04:21
@guqing guqing mentioned this pull request Oct 16, 2024
Merged
f2c-ci-robot bot pushed a commit that referenced this pull request Oct 16, 2024
@guqing
fix: missing ServerWebExchange in plugin template processor extension (…
c577deb 
…#6877)

#### What type of PR is this?
/kind bug
/area core
/milestone 2.20.x

#### What this PR does / why we need it:
修复由 #6680 导致的插件模板处理扩展中无法获取到请求上下文的问题

#6680 修复了插件可以在模板处理扩展中通过请求上下文获取到 Halo 的 ApplicationContext 的问题
但这也引入了新的问题就是导致模板处理扩展无法获取到请求上下文，此 PR 通过判断传递给插件的 ITemplateContext 是否为 IWebContext，如果是则包装为 SecureTemplateWebContext 传递给插件，以解决此问题

#### Which issue(s) this PR fixes:
Fixes #6875

#### Does this PR introduce a user-facing change?
```release-note
修复插件模板处理扩展中无法获取到请求上下文的问题
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing approved these changes

@LIlGG LIlGG Awaiting requested review from LIlGG

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core area/plugin Issues or PRs related to the Plugin Provider kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
2.20.0 LTS
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnNiang @guqing @ruibaby