Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preventing access to login page after Halo setup #6865

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Oct 14, 2024

What type of PR is this?

/kind bug
/area core
/milestone 2.20.x

What this PR does / why we need it:

修复初始化 Halo 之后无法进入登录页面的问题

此问题原因是更改了 AuthProvider 的逻辑,当系统启动之后缺少默认的登录方式导致登录页面无法正确渲染
此 PR 将确保默认的登录方式始终存在来解决此问题

how to test it?
重新初始化 Halo 之后能正确渲染登录页面并登录即为符合预期

Does this PR introduce a user-facing change?

修复初始化 Halo 之后无法进入登录页面的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 14, 2024
Copy link

f2c-ci-robot bot commented Oct 14, 2024

@guqing: The provided milestone is not valid for this repository. Milestones in this repository: [2.19.x, 2.20.x LTS, Backlog]

Use /milestone clear to clear the milestone.

In response to this:

What type of PR is this?

/kind bug
/area core
/milestone 2.20.x

What this PR does / why we need it:

修复初始化 Halo 之后无法进入登录页面的问题

此问题原因是更改了 AuthProvider 的逻辑,当系统启动之后缺少默认的登录方式导致登录页面无法正确渲染
此 PR 将确保默认的登录方式始终存在来解决此问题

how to test it?
重新初始化 Halo 之后能正确渲染登录页面并登录即为符合预期

Does this PR introduce a user-facing change?

修复初始化 Halo 之后无法进入登录页面的问题

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 14, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen October 14, 2024 10:42
@guqing
Copy link
Member Author

guqing commented Oct 14, 2024

/milestone 2.20.x LTS

@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x LTS milestone Oct 14, 2024
Copy link

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.01%. Comparing base (eff73dc) to head (43ec05c).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...run/halo/app/security/AuthProviderServiceImpl.java 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6865      +/-   ##
============================================
+ Coverage     56.99%   57.01%   +0.02%     
- Complexity     3999     4006       +7     
============================================
  Files           714      714              
  Lines         24110    24174      +64     
  Branches       1585     1593       +8     
============================================
+ Hits          13742    13784      +42     
- Misses         9756     9775      +19     
- Partials        612      615       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 45aae9c into halo-dev:main Oct 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants