Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem of not being able to create PAT for OAuth2 user #6870

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR refactors check of whether the current user is a real user to fix the problem of not being able to create PAT for OAuth2 user.

Does this PR introduce a user-facing change?

修复通过 OAuth2 登录之后无法正常创建和恢复个人令牌的问题

Signed-off-by: JohnNiang <johnniang@foxmail.com>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Oct 15, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 15, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 15, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen October 15, 2024 08:40
Copy link

sonarcloud bot commented Oct 15, 2024

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.00%. Comparing base (eff73dc) to head (fdb84da).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...hentication/pat/impl/UserScopedPatHandlerImpl.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6870   +/-   ##
=========================================
  Coverage     56.99%   57.00%           
- Complexity     3999     4003    +4     
=========================================
  Files           714      714           
  Lines         24110    24174   +64     
  Branches       1585     1593    +8     
=========================================
+ Hits          13742    13780   +38     
- Misses         9756     9780   +24     
- Partials        612      614    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2024
Copy link

f2c-ci-robot bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit b95a83a into halo-dev:main Oct 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants