Bind sign up data instead of building by hand #6895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JohnNiang <johnniang@foxmail.com>
f2c-ci-robot
bot
added
kind/improvement
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6895 +/- ##
============================================
+ Coverage 56.99% 57.24% +0.24%
- Complexity 3999 4005 +6
============================================
Files 714 712 -2
Lines 24110 24109 -1
Branches 1585 1592 +7
============================================
+ Hits 13742 13800 +58
+ Misses 9756 9694 -62
- Partials 612 615 +3 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/area core
/milestone 2.20.x
What this PR does / why we need it:
This PR refactors sign up data binding using internal
bindmethod inServerRequestinstead of binding my hand. It's more convenient and simpler.Does this PR introduce a user-facing change?