Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can not return to post list after publishing when re-logged in #6902

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 19, 2024

What type of PR is this?

/area ui
/kind bug
/milestone 2.20.x

What this PR does / why we need it:

修复通过登录跳转到文章编辑页面时,发布文章会跳转到个人中心的问题。

Which issue(s) this PR fixes:

Fixes #6901

Special notes for your reviewer:

测试步骤:

  1. 新建文章,编写内容,但是不发布
  2. 在新的浏览器选项卡中退出登录
  3. 回到文章编辑页面,跳转到登录页面重新登录之后,发布文章
  4. 观察是否会返回到 Console 的文章管理页面。

Does this PR introduce a user-facing change?

修复通过登录跳转到文章编辑页面时,发布文章会跳转到个人中心的问题。

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 19, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 19, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 19, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG October 19, 2024 05:50
Copy link

sonarcloud bot commented Oct 19, 2024

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.22%. Comparing base (eff73dc) to head (ca27dcc).
Report is 21 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6902      +/-   ##
============================================
+ Coverage     56.99%   57.22%   +0.22%     
- Complexity     3999     4005       +6     
============================================
  Files           714      712       -2     
  Lines         24110    24113       +3     
  Branches       1585     1592       +7     
============================================
+ Hits          13742    13799      +57     
+ Misses         9756     9699      -57     
- Partials        612      615       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

我的理解:这里应该是是直接 back 到了 login 页面,导致又被重定向到了 uc 页面。

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2024
Copy link

f2c-ci-robot bot commented Oct 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 500f702 into halo-dev:main Oct 19, 2024
8 checks passed
@ruibaby
Copy link
Member Author

ruibaby commented Oct 19, 2024

/lgtm

我的理解:这里应该是是直接 back 到了 login 页面,导致又被重定向到了 uc 页面。

是的,以前会 back 到 /console,所以不会暴露问题。

@ruibaby ruibaby deleted the fix/post-publish branch October 22, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.20.4 管理员发布文章后,自动跳到了个人中心?
2 participants