Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve button height overflow in signup form on older Safari #6912

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 21, 2024

What type of PR is this?

/area core
/kind bug
/milestone 2.20.x

What this PR does / why we need it:

修复在低版本 Safari 浏览器中,注册表单中的按钮高度溢出的问题。

Which issue(s) this PR fixes:

Fixes #6910

Does this PR introduce a user-facing change?

修复在低版本 Safari 浏览器中,注册表单中的按钮高度溢出的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/core Issues or PRs related to the Halo Core labels Oct 21, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 21, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 21, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen October 21, 2024 08:11
Copy link

sonarcloud bot commented Oct 21, 2024

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.22%. Comparing base (eff73dc) to head (197429f).
Report is 22 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6912      +/-   ##
============================================
+ Coverage     56.99%   57.22%   +0.22%     
- Complexity     3999     4005       +6     
============================================
  Files           714      712       -2     
  Lines         24110    24113       +3     
  Branches       1585     1592       +7     
============================================
+ Hits          13742    13799      +57     
+ Misses         9756     9699      -57     
- Partials        612      615       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
Copy link

f2c-ci-robot bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 53b291b into halo-dev:main Oct 21, 2024
8 checks passed
@ruibaby ruibaby deleted the fix/input-height branch October 21, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

注册表单在低版本 iOS 浏览器上有样式兼容问题
2 participants