Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for creating a new group when uploading attachments #6951

Merged

Conversation

LEIYOUSU
Copy link
Contributor

@LEIYOUSU LEIYOUSU commented Oct 26, 2024

What type of PR is this?

/kind improvement
/area ui
/milestone 2.20.x

What this PR does / why we need it:

支持在附件上传界面创建新分组。

Which issue(s) this PR fixes:

Fixes #6942

Special notes for your reviewer:

Does this PR introduce a user-facing change?

支持在附件上传界面创建新分组。

@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Oct 26, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 26, 2024

CLA assistant check
All committers have signed the CLA.

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 26, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby October 26, 2024 08:11
@ruibaby ruibaby changed the title 支持在上传附件时新建分组#6942 feat: add support for creating a new group when uploading attachments. Oct 26, 2024
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 26, 2024
@ruibaby ruibaby added the area/ui Issues or PRs related to the Halo UI label Oct 26, 2024
@ruibaby ruibaby added this to the 2.20.x milestone Oct 26, 2024
@ruibaby
Copy link
Member

ruibaby commented Oct 26, 2024

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @LEIYOUSU ,感谢参与贡献,在合并之前需要签署一下我们的 CLA 协议。

@ruibaby ruibaby changed the title feat: add support for creating a new group when uploading attachments. feat: add support for creating a new group when uploading attachments Oct 26, 2024
@ruibaby
Copy link
Member

ruibaby commented Oct 26, 2024

另外,看起来有 CI 没过,建议在本地执行一下 pnpm lint

https://github.com/halo-dev/halo/actions/runs/11531383268/job/32102020528?pr=6951

@LEIYOUSU
Copy link
Contributor Author

另外,看起来有 CI 没过,建议在本地执行一下 pnpm lint

https://github.com/halo-dev/halo/actions/runs/11531383268/job/32102020528?pr=6951

非常不好意思,由于是第一次进行PR修改,还不太熟悉,这里运行了pnpm eslint D:\git\halo\halo\ui\console-src\modules\contents\attachments\components\AttachmentUploadModal.vue ,显示需要配置文件,是参照项目中已有的配置文件么?
image

Copy link

@ruibaby
Copy link
Member

ruibaby commented Oct 27, 2024

另外,看起来有 CI 没过,建议在本地执行一下 pnpm lint
https://github.com/halo-dev/halo/actions/runs/11531383268/job/32102020528?pr=6951

非常不好意思,由于是第一次进行PR修改,还不太熟悉,这里运行了pnpm eslint D:\git\halo\halo\ui\console-src\modules\contents\attachments\components\AttachmentUploadModal.vue ,显示需要配置文件,是参照项目中已有的配置文件么? image

没关系,看起来是因为 import 顺序导致的,但这个项目应该会在提交代码之前执行一下 prettier,我不清楚你这边为什么没有自动执行。另外,建议编辑器使用项目内的 Prettier 和 ESLint 规则。

其他地方没有问题,我将合并此 PR,感谢参与贡献~

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2024
Copy link

f2c-ci-robot bot commented Oct 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2024
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.23%. Comparing base (eff73dc) to head (4980d7c).
Report is 40 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6951      +/-   ##
============================================
+ Coverage     56.99%   57.23%   +0.23%     
- Complexity     3999     4005       +6     
============================================
  Files           714      712       -2     
  Lines         24110    24123      +13     
  Branches       1585     1588       +3     
============================================
+ Hits          13742    13806      +64     
+ Misses         9756     9704      -52     
- Partials        612      613       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f2c-ci-robot f2c-ci-robot bot merged commit d44fa5f into halo-dev:main Oct 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

支持在上传附件时新建分组
3 participants