Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for OpenHarmony in device OS detection #7045

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

Anyexyz
Copy link
Contributor

@Anyexyz Anyexyz commented Nov 18, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for detecting OpenHarmony as a device operating system.

Which issue(s) this PR fixes:

Fixes #7039

Special notes for your reviewer:

This PR introduces minor changes in the device OS detection logic.

Does this PR introduce a user-facing change?

新设备登录通知的操作系统名支持显示 OpenHarmony。

@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 18, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG November 18, 2024 05:25
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 18, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Anyexyz , thanks for your contribution!

建议在对应的测试类中添加对应的测试用例:

@Anyexyz
Copy link
Contributor Author

Anyexyz commented Nov 18, 2024

您好,感谢您的贡献!

建议在对应的测试类中添加对应的测试用例:

已添加

@Anyexyz Anyexyz requested a review from JohnNiang November 18, 2024 08:07
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 18, 2024
@guqing
Copy link
Member

guqing commented Nov 18, 2024

Hi @Anyexyz , Check Style 失败了,在合并前需要先解决一下

image

@Anyexyz
Copy link
Contributor Author

Anyexyz commented Nov 18, 2024

Hi @Anyexyz , Check Style 失败了,在合并前需要先解决一下

image

@guqing 已修改

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
Copy link

f2c-ci-robot bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 2c8f6f5 into halo-dev:main Nov 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

${os} 参数识别错误导致邮件中通知为 Unknown
3 participants