Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new tags showing null post count on theme #7049

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Nov 18, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

修复新创建的标签在主题端展示关联文章数量为 null 的问题

Which issue(s) this PR fixes:

Fixes #7042

Does this PR introduce a user-facing change?

修复新创建的标签在主题端展示关联文章数量为 null 的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Nov 18, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Nov 18, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen November 18, 2024 08:25
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.24%. Comparing base (eff73dc) to head (ecbb2df).
Report is 53 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7049      +/-   ##
============================================
+ Coverage     56.99%   57.24%   +0.24%     
- Complexity     3999     4009      +10     
============================================
  Files           714      712       -2     
  Lines         24110    24149      +39     
  Branches       1585     1592       +7     
============================================
+ Hits          13742    13824      +82     
+ Misses         9756     9710      -46     
- Partials        612      615       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

针对旧数据的建议:看能否在这里判断如果为 null 则设置成 0 呢。或者直接更改对应的数据类型为 int

.postCount(tag.getStatusOrDefault().getVisiblePostCount())

@guqing
Copy link
Member Author

guqing commented Nov 19, 2024

针对旧数据的建议:看能否在这里判断如果为 null 则设置成 0 呢。或者直接更改对应的数据类型为 int

.postCount(tag.getStatusOrDefault().getVisiblePostCount())

good catch👍 改了

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024
Copy link

f2c-ci-robot bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 7cef55b into halo-dev:main Nov 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tag.postCount 意外获取到 null
2 participants