-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove template engine after upgrading theme #7057
Remove template engine after upgrading theme #7057
Conversation
2729791
to
4965e83
Compare
4965e83
to
2098964
Compare
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7057 +/- ##
============================================
+ Coverage 56.99% 57.26% +0.26%
- Complexity 3999 4010 +11
============================================
Files 714 712 -2
Lines 24110 24144 +34
Branches 1585 1592 +7
============================================
+ Hits 13742 13826 +84
+ Misses 9756 9704 -52
- Partials 612 614 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area core
/milestone 2.20.x
What this PR does / why we need it:
This PR removes template engine instead of clearing cache of template engine after upgrading theme to resolve incomplete cache clear.
Which issue(s) this PR fixes:
Fixes #7056
Special notes for your reviewer:
theme-earth 1.12.0
上一页
which should be下一页
theme-earth 1.12.1
下一页
directly.Does this PR introduce a user-facing change?