Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove template engine after upgrading theme #7057

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR removes template engine instead of clearing cache of template engine after upgrading theme to resolve incomplete cache clear.

Which issue(s) this PR fixes:

Fixes #7056

Special notes for your reviewer:

  1. Try to install the theme theme-earth 1.12.0
  2. Request index page and you will see the 上一页 which should be 下一页
  3. Try to upgrade to the theme theme-earth 1.12.1
  4. Request index page and you should see the 下一页 directly.

Does this PR introduce a user-facing change?

修复升级主题后语言包未更新的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Nov 20, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Nov 20, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Nov 20, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG November 20, 2024 04:30
@JohnNiang JohnNiang force-pushed the bug/template-message-cache branch from 2729791 to 4965e83 Compare November 20, 2024 04:34
@JohnNiang JohnNiang force-pushed the bug/template-message-cache branch from 4965e83 to 2098964 Compare November 20, 2024 04:35
Copy link

sonarcloud bot commented Nov 20, 2024

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.26%. Comparing base (eff73dc) to head (2098964).
Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
...java/run/halo/app/theme/TemplateEngineManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7057      +/-   ##
============================================
+ Coverage     56.99%   57.26%   +0.26%     
- Complexity     3999     4010      +11     
============================================
  Files           714      712       -2     
  Lines         24110    24144      +34     
  Branches       1585     1592       +7     
============================================
+ Hits          13742    13826      +84     
+ Misses         9756     9704      -52     
- Partials        612      614       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit d75bb09 into halo-dev:main Nov 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

主题语言资源在更新主题后存在缓存
3 participants