Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump vite version to 6.0.3 #7123

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 10, 2024

What type of PR is this?

/area ui
/kind improvement

What this PR does / why we need it:

Bump vite version to 6

Does this PR introduce a user-facing change?

None

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Dec 10, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen December 10, 2024 02:59
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.23%. Comparing base (eff73dc) to head (52219b7).
Report is 80 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7123      +/-   ##
============================================
+ Coverage     56.99%   57.23%   +0.23%     
- Complexity     3999     4048      +49     
============================================
  Files           714      719       +5     
  Lines         24110    24352     +242     
  Branches       1585     1598      +13     
============================================
+ Hits          13742    13937     +195     
- Misses         9756     9798      +42     
- Partials        612      617       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing
Copy link
Member

guqing commented Dec 10, 2024

build 失败了

Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link

pkg-pr-new bot commented Dec 10, 2024

Open in Stackblitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7123

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7123

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7123

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7123

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7123

commit: 52219b7

@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2024
@JohnNiang
Copy link
Member

JohnNiang commented Dec 16, 2024

Hi @ruibaby, there have conflicts that must be resolved before merging.

@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2024
@ruibaby ruibaby requested review from JohnNiang and LIlGG December 16, 2024 04:53
@ruibaby
Copy link
Member Author

ruibaby commented Dec 16, 2024

Hi @ruibaby, there has conflicts that must be resolved before merging.

Fixed

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
Copy link

f2c-ci-robot bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit f9ddeeb into halo-dev:main Dec 16, 2024
11 checks passed
@ruibaby ruibaby deleted the chore/bump-vite-version branch December 16, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants