Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump comment widget package version to supports custom account #9

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 16, 2023

更新 @halo-dev/comment-widget 的版本以支持自填写用户信息评论。

image

参考:

  1. feat: add create comment by custom account support halo-sigs/comment-widget#2

/kind feature

Fixes #2
Fixes halo-dev/halo#3116

测试方式:

  1. 安装测试插件:plugin-comment-widget-1.0.0-SNAPSHOT.jar.zip
  2. 测试自填写用户来评论。
  3. 测试登录用户评论。
  4. 测试退出登录。
支持访客自填写用户信息以评论。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 16, 2023
@ZHU-SK
Copy link

ZHU-SK commented Jan 16, 2023

更新 @halo-dev/comment-widget 的版本以支持自填写用户信息评论。

image

参考:

  1. feat: add create comment by custom account support comment-widget#2

/kind feature

Fixes #2 Fixes halo-dev/halo#3116

测试方式:

  1. 安装测试插件:plugin-comment-widget-1.0.0-SNAPSHOT.jar.zip
  2. 测试自填写用户来评论。
  3. 测试登录用户评论。
  4. 测试退出登录。
支持访客自填写用户信息以评论。

请问可以设置为邮箱选填么?很多朋友想评论但不想输入邮箱地址;以及可否增加去掉“个人网站”这一栏的选项呢,很多朋友也都没有主页。谢谢您。

@ruibaby
Copy link
Member Author

ruibaby commented Jan 17, 2023

请问可以设置为邮箱选填么?很多朋友想评论但不想输入邮箱地址;以及可否增加去掉“个人网站”这一栏的选项呢,很多朋友也都没有主页。谢谢您。

不是此 PR 的重点,可以放在后面修改。

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ruibaby ruibaby added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 28741d3 into halo-dev:main Jan 30, 2023
@ruibaby ruibaby deleted the feat/bump-comment-widget-version branch January 30, 2023 14:55
@CnDaiL
Copy link

CnDaiL commented Jan 31, 2023

已经填写了 个人网站这一览的, 一把名字是超链接,但是这里没有啊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

对于匿名评论的一些建议 评论登录状态无法登出
5 participants