Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Time placeholder of upload path #74

Merged
merged 3 commits into from
Sep 27, 2023
Merged

feat: Time placeholder of upload path #74

merged 3 commits into from
Sep 27, 2023

Conversation

AccAutomaton
Copy link
Contributor

Fixes #69

文件上传路径支持使用`${year}`,`${month}`,`${day}`占位符

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 19, 2023
@AccAutomaton AccAutomaton mentioned this pull request Sep 19, 2023
Closed
@AccAutomaton
Copy link
Contributor Author

@longjuan
image
在link中似乎不需要修改getter？我不太了解link部分的原理

@longjuan
Copy link
Member

longjuan commented Sep 19, 2023 •
edited
Loading

在link中似乎不需要修改getter？我不太了解link部分的原理

需要，要把这两处修改成新方法。

@AccAutomaton
Copy link
Contributor Author

可以了

longjuan
longjuan reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@longjuan longjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@longjuan
Copy link
Member

/remove-lgtm

@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
longjuan
longjuan reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@longjuan longjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@longjuan
Copy link
Member

/ping @halo-dev/sig-halo

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 217f1db into halo-dev:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longjuan longjuan longjuan left review comments

@guqing guqing guqing approved these changes

@JohnNiang JohnNiang Awaiting requested review from JohnNiang

Assignees

@longjuan longjuan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

建议可以增加一个自动创建年份的目录。目前上传是全部上传到桶的根目录下面。
3 participants
@AccAutomaton @longjuan @guqing