feat: add new rfc for generating and managing attachment thumbnails #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
the
do-not-merge/release-note-label-needed
This was referenced Aug 9, 2024
Merged
f2c-ci-robot
bot
added
release-note-none
guqing
force-pushed
the
feature/thumbnail
branch
from
f1f9590
to
f624f1d
Compare
f2c-ci-robot bot
pushed a commit
to halo-dev/halo
that referenced
this pull request
Aug 26, 2024
… thumbnails (#6454) #### What type of PR is this? /kind feature /area core /milestone 2.19.x #### What this PR does / why we need it: 实现了图片类型的附件缩略图生成和管理的新机制 实现依据 RFC：halo-dev/rfcs#24 使用缩略图前需要配置 externalUrl 才能生成 **How to test it?** 1. 测试本地缩略图的文件是否正确，每个图片对应到相应 size 的目录如 thumbnails/w400 应该是一对一 2. 每个图片生成缩略图的只会在 `http://localhost:8090/apis/storage.halo.run/v1alpha1/thumbnails` 中存在一份记录 3. 测试删除附件会删除对应的缩略图文件和 [thumbnails](http://localhost:8090/apis/storage.halo.run/v1alpha1/thumbnails) 记录 4. 修改 externalUrl 以上功能均不会受到影响 #### Which issue(s) this PR fixes: Fixes #2387 #### Does this PR introduce a user-facing change? ```release-note 附件图片支持生成多尺寸图片，文章支持响应式图片。 ```
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does?
新增附件缩略图生成的 RFC