Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add condition for icp config #176

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Anyexyz
Copy link
Contributor

@Anyexyz Anyexyz commented Sep 2, 2024

None

@f2c-ci-robot f2c-ci-robot bot requested a review from guqing September 2, 2024 14:49
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 2, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from lan-yonghui September 2, 2024 14:49
@ruibaby ruibaby changed the title 修复没有配置ICP备案号时存在span占位的问题 refactor: add condition for icp config Sep 4, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
Copy link

f2c-ci-robot bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 4, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit fb961e7 into halo-dev:main Sep 4, 2024
1 check passed
@Anyexyz Anyexyz deleted the fix-footer branch September 4, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants