Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the problem of not displaying while configuring ICP only #196

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Fix the problem of not displaying while configuring ICP only #196

merged 1 commit into from
Oct 24, 2024

Conversation

Anyexyz
Copy link
Contributor

@Anyexyz Anyexyz commented Oct 23, 2024 •
edited by ruibaby
Loading 

修复只填写了 ICP 备案号时不显示的问题

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 23, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang October 23, 2024 06:42
@JohnNiang
Copy link
Member

/retitle Fix the problem of not displaying while configuring ICP only

@f2c-ci-robot f2c-ci-robot bot changed the title 修复只填写了ICP备案号时不显示的问题 Fix the problem of not displaying while configuring ICP only Oct 23, 2024
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 24, 2024
ruibaby
ruibaby approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit a6a68da into halo-dev:main Oct 24, 2024
1 check passed
@JohnNiang JohnNiang mentioned this pull request Oct 24, 2024
Closed
@JohnNiang
Copy link
Member

请求发布 1.10.1。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby approved these changes

@guqing guqing Awaiting requested review from guqing

@JohnNiang JohnNiang Awaiting requested review from JohnNiang

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anyexyz @JohnNiang @ruibaby