Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

perf: improve comments by anonymous user #4

Merged
merged 1 commit into from
Feb 3, 2023
Merged

perf: improve comments by anonymous user #4

merged 1 commit into from
Feb 3, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 30, 2023 •
edited
Loading

优化匿名访客评论的判断方式，依赖于 halo-dev/halo#3182

现在的逻辑修改为：

  1. 如果在设置中勾选了 仅允许注册用户评论 选项，那么不会显示自定义评论者的表单。
  2. 如果取消勾选 仅允许注册用户评论 选项，会同时支持自定义评论者信息和登录。

image

image

/kind improvement

优化匿名访客评论的判断方式

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 30, 2023
JohnNiang
JohnNiang approved these changes Feb 3, 2023
View reviewed changes
Copy link

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

guqing
guqing reviewed Feb 3, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2023
@ruibaby ruibaby added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit c4dbe90 into halo-sigs:main Feb 3, 2023
@ruibaby ruibaby deleted the feat/allowAnonymousComments branch February 3, 2023 03:51
@ruibaby ruibaby mentioned this pull request Feb 21, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruibaby @JohnNiang @guqing