Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UI with Basic CRUD Functionality #6

Merged
merged 17 commits into from
Jul 25, 2024

Conversation

CaiHaosen
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

此 PR 实现了代码注入插件的管理界面以及基本的增删改查,详情界面还未实现

Which issue(s) this PR fixes:

Fixes #4

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 12, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby July 12, 2024 05:04
@CaiHaosen
Copy link
Collaborator Author

更改package.json中的依赖后再次提交

@CaiHaosen CaiHaosen requested a review from ruibaby July 16, 2024 08:16
@CaiHaosen CaiHaosen requested a review from guqing July 19, 2024 02:51
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里有两个关于表单提交的建议。

具体可参考:Submitting via XHR/Fetch request

@CaiHaosen CaiHaosen requested review from ruibaby and guqing July 24, 2024 06:53
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2024
Copy link

f2c-ci-robot bot commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 864f49b into halo-sigs:main Jul 25, 2024
2 checks passed
guqing pushed a commit to guqing/plugin-injection that referenced this pull request Sep 30, 2024
#### What type of PR is this?
/kind feature
#### What this PR does / why we need it:
此 PR 实现了代码注入插件的管理界面以及基本的增删改查,详情界面还未实现
#### Which issue(s) this PR fixes:
Fixes halo-sigs#4 
#### Does this PR introduce a user-facing change?
```release-note
None
```
CaiHaosen added a commit that referenced this pull request Oct 9, 2024
#### What type of PR is this?
/kind feature
#### What this PR does / why we need it:
此 PR 实现了代码注入插件的管理界面以及基本的增删改查,详情界面还未实现
#### Which issue(s) this PR fixes:
Fixes #4 
#### Does this PR introduce a user-facing change?
```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

设计插件界面并实现基本增删改查功能
3 participants