Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle missing name for social bingding #57

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

guqing
Copy link
Member

@guqing guqing commented Aug 2, 2024

What this PR does?

修复 GitHub 显示名称未设置时无法绑定的问题

/kind bug

Fixes #51
Fixes #14
Fixes #44

修复 GitHub 显示名称未设置时无法绑定的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Aug 2, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby August 2, 2024 06:34
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2024
Copy link

f2c-ci-robot bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 8d5ad2b into main Aug 2, 2024
2 checks passed
@guqing guqing deleted the fix/51 branch August 2, 2024 06:36
@guqing guqing mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
2 participants