This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
refactor: editor bubble menu and its extensions #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
/retitle refactor: editor bubble menu and its extensions |
f2c-ci-robot
bot
changed the title
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
|
/lgtm |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
What this PR does / why we need it:
此 PR 重构了编辑器冒泡菜单，之后冒泡菜单的声明及创建可与组件 DOM 分离，并且本 PR 优化了菜单的样式及表现。
现在冒泡菜单不再响应移向目标组件的事件而改为点击某个组件出现，这更加符合编辑操作和体验，也不会出现类似于 halo-dev/halo#3208 的无法选中的问题。且此次修改向下兼容，若插件使用旧版本的冒泡菜单则不会受到影响。
before:
after:
todo:
How to test it?
查看编辑器各块元素的冒泡菜单功能是否正常。
Does this PR introduce a user-facing change?