Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

feat: add supports for image with link #49

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

GodlessLiu
Copy link
Contributor

@GodlessLiu GodlessLiu commented Sep 15, 2023

为图片添加外部a标签,支持图片跳转。
fixes halo-dev/halo#4406

支持为图片添加跳转链接

@vercel
Copy link

vercel bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
richtext-editor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2023 6:46am

@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen September 15, 2023 07:21
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 15, 2023
packages/editor/src/locales/zh-CN.yaml Outdated Show resolved Hide resolved
packages/editor/src/locales/zh-CN.yaml Outdated Show resolved Hide resolved
@ruibaby ruibaby changed the title feat: add outside a href for image feat: add supports for image with link Sep 25, 2023
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 25, 2023
@ruibaby
Copy link
Member

ruibaby commented Sep 25, 2023

@GodlessLiu 需要处理一下冲突。

packages/editor/src/locales/en.yaml Outdated Show resolved Hide resolved
packages/editor/src/locales/en.yaml Outdated Show resolved Hide resolved
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2023
Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

image

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit bc7bb08 into halo-sigs:main Sep 25, 2023
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

升级到2.8后默认编辑器无法为图片增加超链接
3 participants