Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

pref: change the display of block-level inline elements to inline-block #53

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Sep 19, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

将部分块元素改为内联块,用以解决元素后带有空行的问题

Which issue(s) this PR fixes:

Fixes #52

Does this PR introduce a user-facing change?

解决部分元素后带有空行的问题

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
richtext-editor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 10:36am

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Sep 19, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen September 19, 2023 10:35
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This is amazing!

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 1c9be1d into halo-sigs:main Sep 20, 2023
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

部分元素组件后会附带一个空行
3 participants