Fix TS typings #75
Merged
Fix TS typings #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yo @IKnowBashFu, thanks for the fix! Not much of a typescript user myself so I figured they might be a bit off. I'll put out a patch release with this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this library for TS in Visual Studio Code, none of the typings were actually loading. This is due to the lack of a "types" key in the package.json, so I added that.
Then, tsc was complaining that I couldn't import your library, as it wasn't a module. For this, I added
exportin front of your two class declarations inside the typings file for ts, then removed the export at the bottom.