Fix: record MarshalJSON in case of default record with nullable field #451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across the following case where record
MarshalJSON
generates an Invalid schema, whichavro.Parse
fails to parse, returning the error:Schema:
The generated invalid schema:
The default value of
c
should benull
instead of an empty JSON object.If I got it right, a fix could be to define a custom
MarshalJSON
for thenullDefault
value: