Fix breakages due to Mypy chages #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essages have changed somewhat, which breaks our build. I've changed some tests to reflect the changes. One useful thing, too - the new mypy pointed out an unannotated function, albeit an internal one.
brunns
changed the title
offbyone
approved these changes
Nov 14, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy 0.990 has been released, and it appears that some of the error messages have changed somewhat, which breaks our build. I've changed some tests to reflect the changes, hopefully fixing #220.
One useful thing, too - the new mypy pointed out an unannotated function, albeit an internal one.