Fix CI from PR 930

hamdanal · May 26, 2024 · 6ecbab9 · 6ecbab9
1 parent 8a41508
commit 6ecbab9
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 16 deletions.
diff --git a/pandas-stubs/core/groupby/generic.pyi b/pandas-stubs/core/groupby/generic.pyi
@@ -207,7 +207,7 @@ class DataFrameGroupBy(GroupBy[DataFrame], Generic[ByT]):
     ) -> DataFrame: ...
     # error: overload 1 overlaps overload 2 because of different return types
     @overload
-    def aggregate(self, func: Literal["size"]) -> Series: ...  # type: ignore[overload-overlap]  # pyright: ignore[reportOverlappingOverload]
+    def aggregate(self, func: Literal["size"]) -> Series: ...  # type: ignore[overload-overlap]
     @overload
     def aggregate(
         self,

diff --git a/tests/test_plotting.py b/tests/test_plotting.py
@@ -486,22 +486,23 @@ def test_plot_scatter(close_figures) -> None:
         ),
         Axes,
     )
-    check(
-        assert_type(
-            IRIS_DF.plot.scatter(x="SepalLength", y="SepalWidth", subplots=True),
-            npt.NDArray[np.object_],
-        ),
-        np.ndarray,
-    )
-    check(
-        assert_type(
-            IRIS_DF.plot(
-                x="SepalLength", y="SepalWidth", subplots=True, kind="scatter"
+    with pytest.warns(UserWarning):
+        check(
+            assert_type(
+                IRIS_DF.plot.scatter(x="SepalLength", y="SepalWidth", subplots=True),
+                npt.NDArray[np.object_],
             ),
-            npt.NDArray[np.object_],
-        ),
-        np.ndarray,
-    )
+            np.ndarray,
+        )
+        check(
+            assert_type(
+                IRIS_DF.plot(
+                    x="SepalLength", y="SepalWidth", subplots=True, kind="scatter"
+                ),
+                npt.NDArray[np.object_],
+            ),
+            np.ndarray,
+        )
 
 
 def test_plot_keywords(close_figures):