Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes issue with docker container deploy to heroku #165

Merged
merged 3 commits into from
Jan 17, 2018
Merged

fixes issue with docker container deploy to heroku #165

merged 3 commits into from
Jan 17, 2018

Conversation

jackcmeyer
Copy link
Member

fixes #151

  • removes the -e flag from the .travis.yml generated file
  • updates relevant test

@jackcmeyer jackcmeyer requested a review from nischayv January 16, 2018 23:46
nischayv
nischayv requested changes Jan 16, 2018
View reviewed changes
Copy link
Member

@nischayv nischayv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also the part where we set environment variables in Travis through the API. Get rid of the email environment variable - HEROKU_EMAIL

@nischayv nischayv merged commit cc23d93 into master Jan 17, 2018
@nischayv nischayv deleted the fix-151-heroku-deploy branch January 17, 2018 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nischayv nischayv nischayv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Docker deploy to Heroku
2 participants
@jackcmeyer @nischayv