Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateRecording #88

Merged
merged 2 commits into from
Dec 3, 2024
Merged

CreateRecording #88

merged 2 commits into from
Dec 3, 2024

Conversation

paoloo
Copy link
Collaborator

@paoloo paoloo commented Dec 2, 2024 •
edited
Loading

Onvif.Recording.CreateRecording

Tested on

Video
Axis ✔️
Uniview ✔️
Hikivision ❓
Dahua ❓

@paoloo paoloo requested a review from yuriploc December 2, 2024 21:16
yuriploc
yuriploc approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@yuriploc yuriploc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Onvif.Recording.Recordings is weird, but I get where that comes from, as Onvif.Recording is the service namespace and Onvif.Recording.Recording is still weird.

@paoloo paoloo marked this pull request as ready for review December 2, 2024 22:58
@paoloo paoloo requested a review from hammeraj as a code owner December 2, 2024 22:58
@paoloo paoloo requested a review from hammeraj December 3, 2024 18:31
hammeraj
hammeraj approved these changes Dec 3, 2024
View reviewed changes
Copy link
Owner

@hammeraj hammeraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hammeraj hammeraj merged commit e6d3ea3 into main Dec 3, 2024
1 check passed
@hammeraj hammeraj deleted the po/create_recording branch December 3, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hammeraj hammeraj hammeraj approved these changes

@yuriploc yuriploc yuriploc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paoloo @yuriploc @hammeraj