Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointer events bug with multiple pointers for mouse in IE #664

Closed
jbrantly opened this issue Sep 11, 2014 · 0 comments · Fixed by #665
Closed

Pointer events bug with multiple pointers for mouse in IE #664

jbrantly opened this issue Sep 11, 2014 · 0 comments · Fixed by #665

Comments

@jbrantly
Copy link
Contributor

I noticed that in some cases it was possible to create a "pinch" gesture in IE11 on the destkop even though I was only using the mouse. Looking deeper, it turns out that when I dragged an image IE fired the mousedown event but not the mouseup event. If I did it again, hammerjs registered that as two separate pointers and started firing the pinch event. Example here:

http://jsfiddle.net/jbrantly/410zu0wn/

I'm using Windows 7 IE 11. I'm guessing it's broken on any IE that supports pointer events. To duplicate, click and drag the image so that you get the ghost image effect. Let go of the image. Then do it again and you will see pinch events fired.

I've created a fix locally and I'm working on a PR now.
jbrantly added a commit to jbrantly/hammer.js that referenced this issue Sep 11, 2014
@jbrantly
Fixing pointer events bug falsely detecting multiple pointers
9640e68 
It is possible for IE to fire a "down" event without a corresponding "up"
event. If this happens, a new "down" event will be falsely added as an
additional pointer. This commit first makes sure the pointer from the
down event is not already in the store before adding it (based on
pointerId).

Fixes hammerjs#664
@jbrantly jbrantly mentioned this issue Sep 11, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing pointer events bug falsely detecting multiple pointers jbrantly/hammer.js
1 participant
@jbrantly