Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API URLs to typical path, update other links, and use https #163

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

Xymph
Copy link
Collaborator

@Xymph Xymph commented Feb 22, 2024

I noticed a few http links now redirect to https, and an extended URL scan pointed to some other links also worth updating.

@Xymph Xymph requested a review from waldyrious February 22, 2024 16:38
@Xymph
Copy link
Collaborator Author

Xymph commented Feb 22, 2024

Hmm, looks like markdownlint needs to be taught how to accept our changelog.

@Xymph
Copy link
Collaborator Author

Xymph commented Feb 29, 2024

Hey @waldyrious, could you please resolve this GH action problem? Thanks.

@waldyrious
Copy link
Collaborator

Hmm, it seems they changed the configuration of MD024 to only accept siblings_only rather than allow_different_nesting, which is what we used.

We need to change this code:

# MD024/no-duplicate-heading
MD024:
# Only check sibling headings
allow_different_nesting: true

 # MD024/no-duplicate-heading
 MD024:
   # Only check sibling headings
-  allow_different_nesting: true
+  siblings_only: true

Do you want to do that in this PR, or should we make it a separate one?

@Xymph
Copy link
Collaborator Author

Xymph commented Apr 22, 2024

Welcome back. The clean way would be a separate PR, tbh - unless that's overkill? This PR is kind of a clean-up thingy already... your call.

@Xymph Xymph removed the request for review from waldyrious June 24, 2024 13:32
@Xymph Xymph merged commit 3198588 into hamstar:master Jun 24, 2024
2 checks passed
@Xymph
Copy link
Collaborator Author

Xymph commented Jun 24, 2024

@waldyrious The silence has been deafening long enough. 😜

I fixed the markdown rule in this PR and merged it per the Governance rule 2 exception.

@Xymph Xymph deleted the 163-update-urls branch June 24, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants