Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROM 4.2 #490

Merged
merged 33 commits into from
Jun 25, 2018
Merged

ROM 4.2 #490

merged 33 commits into from
Jun 25, 2018

Conversation

jodosha
Copy link
Member

@jodosha jodosha commented Jun 18, 2018

Migrate to ROM 4.2

Piotr Solnica and others added 30 commits June 10, 2018 23:12
@jodosha jodosha added this to the v2.0.0 milestone Jun 18, 2018
@jodosha jodosha self-assigned this Jun 18, 2018
@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #490 into unstable will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #490      +/-   ##
============================================
+ Coverage     98.73%   98.75%   +0.01%     
============================================
  Files           108      108              
  Lines          5535     5539       +4     
============================================
+ Hits           5465     5470       +5     
+ Misses           70       69       -1
Impacted Files Coverage Δ
spec/unit/hanami/model/sql/schema/int_spec.rb 100% <ø> (ø) ⬆️
spec/unit/hanami/model/sql/schema/float_spec.rb 100% <ø> (ø) ⬆️
spec/unit/hanami/model/sql/schema/time_spec.rb 100% <ø> (ø) ⬆️
spec/unit/hanami/model/sql/schema/array_spec.rb 100% <ø> (ø) ⬆️
spec/unit/hanami/model/sql/schema/decimal_spec.rb 100% <ø> (ø) ⬆️
spec/unit/hanami/model/sql/schema/date_spec.rb 100% <ø> (ø) ⬆️
...c/integration/hanami/model/repository/base_spec.rb 96.19% <ø> (ø) ⬆️
spec/unit/hanami/model/sql/schema/hash_spec.rb 100% <ø> (ø) ⬆️
...pec/unit/hanami/model/sql/schema/date_time_spec.rb 100% <ø> (ø) ⬆️
spec/unit/hanami/model/migrator/sqlite.rb 99.59% <100%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d252281...5f8c7db. Read the comment docs.

@BenBach
Copy link

BenBach commented Jun 25, 2018

Hi Luca,

Nice :-) I realize this PR is for hanami 2.0. I hope you don't mind me asking: Is it possible to use this with hanami 1.2 (of course at own risk and with a fork:-)?
There seem to be not so many breaking changes.

Would love to use new ROM functionality like each_batch.

Thank you already in advance.
-Ben

Copy link
Member

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except messy commit history :)

@jodosha
Copy link
Member Author

jodosha commented Jun 25, 2018

@BenBach Yes, it's theoretically possible, even if I haven't tried yet.
Please ping me at any time if you'll find problems.


On a side note, we're planning to release these changes sooner than expected. In order to make the upgrade smoother, we want to split previously planned changes in Hanami 2 and 3.

The first batch, will have ROM 4 (this PR) and minor features/breaking changes.
Whereas Hanami 3 will ship with Action and View changes.

@jodosha
Copy link
Member Author

jodosha commented Jun 25, 2018

@solnic Thanks for the review. It's probably better to squash and merge these commits, and manually give credit for the changes in CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants