-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROM 4.2 #490
ROM 4.2 #490
Conversation
…atabase => Ruby coercion fails
Codecov Report
@@ Coverage Diff @@
## unstable #490 +/- ##
============================================
+ Coverage 98.73% 98.75% +0.01%
============================================
Files 108 108
Lines 5535 5539 +4
============================================
+ Hits 5465 5470 +5
+ Misses 70 69 -1
Continue to review full report at Codecov.
|
Hi Luca, Nice :-) I realize this PR is for hanami 2.0. I hope you don't mind me asking: Is it possible to use this with hanami 1.2 (of course at own risk and with a fork:-)? Would love to use new ROM functionality like Thank you already in advance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except messy commit history :)
@BenBach Yes, it's theoretically possible, even if I haven't tried yet. On a side note, we're planning to release these changes sooner than expected. In order to make the upgrade smoother, we want to split previously planned changes in Hanami 2 and 3. The first batch, will have ROM 4 (this PR) and minor features/breaking changes. |
@solnic Thanks for the review. It's probably better to squash and merge these commits, and manually give credit for the changes in CHANGELOG. |
Migrate to ROM 4.2