Update dry-types #563
Merged
Update dry-types #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mereghost
force-pushed
the
update-dry-types
branch
2 times, most recently
from
21c75b0 to
9b6dedb
Compare
mereghost
force-pushed
the
update-dry-types
branch
from
9b6dedb to
576452e
Compare
mereghost
force-pushed
the
update-dry-types
branch
from
32b7c0a to
211ec49
Compare
| @@ -24,7 +24,7 @@ Gem::Specification.new do |spec| | |||
| spec.add_runtime_dependency "rom", "~> 5.1" | |||
| spec.add_runtime_dependency "rom-repository", "~> 5.1" | |||
| spec.add_runtime_dependency "rom-sql", "~> 3.0" | |||
| spec.add_runtime_dependency "dry-types", "~> 1.1" | |||
| spec.add_runtime_dependency "dry-types", "~> 1.2" | |||
There was a problem hiding this comment.
WDYT if we set 1.3 version instead 1.2? in this case, we'll able to use latest dry-system and I'll have an ability to test my library for dry-system dependency graph 🤔
There was a problem hiding this comment.
IIRC it wasn't available at the time I made the changes. I'll give it a try and see how it goes.
There was a problem hiding this comment.
Okay, updating to 1.3 introduces new issues. I'll merge this, and open a new one to 1.3 otherwise it will get confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes model alpha releasable. =)
We had an issue with dry-types
1.2removing.metafrom structs, which Nikita promptly fixed.