Allow installation with Symfony 6 and fix phpstan and code-style #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-rath
commented
Nov 4, 2022
| @@ -5,27 +5,26 @@ | |||
| "description": "Provide resource functionality for Sulu CMS.", | |||
| "require": { | |||
| "php": "^7.2 || ^8.0", | |||
| "doctrine/collections": "^1.6", | |||
There was a problem hiding this comment.
Didn't find a class with a dependency on this package
luca-rath
commented
Nov 4, 2022
| env: ${{ matrix.env }} | ||
|
|
||
| - name: Execute test cases | ||
| run: time composer test |
There was a problem hiding this comment.
There are no tests in this repository, therefore I removed all of this
| @@ -9,85 +8,22 @@ on: | |||
| - '[0-9]+.[0-9]+' | |||
|
|
|||
| jobs: | |||
| test: | |||
There was a problem hiding this comment.
🙈 not the best that we don't have any tests in this bundle.
alexander-schranz
approved these changes
Nov 7, 2022
alexander-schranz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.