Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hello World in CSS #112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TariCodes
Copy link

@TariCodes TariCodes commented Oct 22, 2024

PR Type

enhancement


Description

  • Introduced a new CSS file to display "Hello, World!!" in a styled paragraph.
  • Applied styles include light blue color, 18px font size, and bold font weight.

Changes walkthrough 📝

Relevant files
Enhancement
hello_world.css
Add Hello World styling in CSS                                                     

contributions/CSS/hello_world.css

  • Added a CSS rule for a paragraph element.
  • Set the content to "Hello, World!!".
  • Styled the text with light blue color, 18px font size, and bold font
    weight.
  • +6/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Incorrect Usage
    The content property is not typically used for setting text content in a paragraph element. It's mainly used with pseudo-elements.

    Formatting Issue
    There's no space after the comma in "Hello,World!!". This might affect the visual output.

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Use pseudo-elements for setting content in CSS

    Use the ::before or ::after pseudo-element to set the content property, as it
    doesn't work directly on

    elements.

    contributions/CSS/hello_world.css [1-6]

    +p::before {
    +  content: "Hello, World!!";
    +}
     p {
    -  content: "Hello,World!!";
       color: lightblue;
       font-size: 18px;
       font-weight: 600;
     }
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion correctly identifies that the content property cannot be applied directly to <p> elements and proposes using ::before or ::after pseudo-elements, which is a crucial fix for the intended functionality.

    9
    Enhancement
    Improve text formatting for better readability

    Add a space after the comma in "Hello,World!!" for proper punctuation.

    contributions/CSS/hello_world.css [2]

    -content: "Hello,World!!";
    +content: "Hello, World!!";
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: The suggestion improves readability by adding a space after the comma in "Hello,World!!", which is a minor but beneficial enhancement for text formatting.

    7

    💡 Need additional feedback ? start a PR chat

    @handikatriarlan
    Copy link
    Owner

    CSS has been created before, please create hello world in another language or you can add numeric at the end of the file, for example: hello_world_2.css

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants