feat: default options for controlling proto access #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nknapp
force-pushed
the
protoAccessDefaultOptions
branch
2 times, most recently
from
6ed0598 to
f330390
Compare
|
👍 thanks! Looks like this is a good balance between protecting users by default and allowing them the flexibility to continue using prototype methods in projects where that is necessary. |
nknapp
force-pushed
the
protoAccessDefaultOptions
branch
from
f330390 to
f6d29eb
Compare
This commmit adds the runtime options - `allowProtoPropertiesByDefault` (boolean, default: false) and - `allowProtoMethodsByDefault` (boolean, default: false)` which can be used to allow access to prototype properties and functions in general. Specific properties and methods can still be disabled from access via `allowedProtoProperties` and `allowedProtoMethods` by setting the corresponding values to false. The methods `constructor`, `__defineGetter__`, `__defineSetter__`, `__lookupGetter__` and the property `__proto__` will be disabled, even if the allow...ByDefault-options are set to true. In order to allow access to those properties and methods, they have to be explicitly set to true in the 'allowedProto...'-options. A warning is logged when the a proto-access it attempted and denied by default (i.e. if no option is set by the user to make the access decision explicit)
nknapp
force-pushed
the
protoAccessDefaultOptions
branch
from
f6d29eb to
1b5a0ef
Compare
This was referenced Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: default options for controlling proto access
This commmit adds the runtime options
allowProtoPropertiesByDefault(boolean, default: false) andallowProtoMethodsByDefault(boolean, default: false)`which can be used to allow access to prototype properties and
functions in general.
Specific properties and methods can still be disabled from access
via
allowedProtoPropertiesandallowedProtoMethodsbysetting the corresponding values to false.
The methods
constructor,__defineGetter__,__defineSetter__,__lookupGetter__and the property
__proto__will be disabled, even if the allow...ByDefault-optionsare set to true. In order to allow access to those properties and methods, they have
to be explicitly set to true in the 'allowedProto...'-options.
A warning is logged when the a proto-access it attempted and denied
by default (i.e. if no option is set by the user to make the access
decision explicit)