wallet: don't add coinbase txs to the pending list.

handshake-org · Oct 27, 2023 · 84ec945 · 84ec945
1 parent bb7da60
commit 84ec945
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 4 deletions.
diff --git a/lib/wallet/txdb.js b/lib/wallet/txdb.js
@@ -1304,7 +1304,7 @@ class TXDB {
    * database. Disconnect inputs.
    * @private
    * @param {TXRecord} wtx
-   * @returns {Promise<Details?>}
+   * @returns {Promise<Details>}
    */
 
   async erase(wtx, block) {
@@ -1495,7 +1495,7 @@ class TXDB {
    * @private
    * @param {Hash} hash
    * @param {Number} height
-   * @returns {Promise}
+   * @returns {Promise<Details?>}
    */
 
   async unconfirm(hash, height) {
@@ -1522,13 +1522,18 @@ class TXDB {
     if (wtx.height === -1)
       return null;
 
+    const tx = wtx.tx;
+
+    if (tx.isCoinbase())
+      return this.removeRecursive(wtx);
+
     return this.disconnect(wtx, wtx.getBlock());
   }
 
   /**
    * Unconfirm a transaction. Necessary after a reorg.
    * @param {TXRecord} wtx
-   * @returns {Promise}
+   * @returns {Promise<Details>}
    */
 
   async disconnect(wtx, block) {
@@ -2947,7 +2952,7 @@ class TXDB {
   /**
    * Get transaction.
    * @param {Hash} hash
-   * @returns {Promise} - Returns {@link TX}.
+   * @returns {Promise<TXRecord>}
    */
 
   async getTX(hash) {

diff --git a/test/wallet-test.js b/test/wallet-test.js
@@ -382,6 +382,51 @@ describe('Wallet', function() {
     }
   });
 
+  it('should remove unconfirmed coinbase tx', async () => {
+    const wallet = await wdb.create();
+
+    const block = nextBlock(wdb);
+    const normalTX = new MTX();
+
+    normalTX.addInput(dummyInput());
+    normalTX.addOutput(await wallet.receiveAddress(), 5000);
+
+    assert(!normalTX.isCoinbase());
+
+    const cbTX = new MTX();
+
+    cbTX.addInput({
+      prevout: new Outpoint()
+    });
+
+    cbTX.addOutput(await wallet.receiveAddress(), 5000);
+    assert(cbTX.isCoinbase());
+
+    const pendingBefore = await wallet.getPending();
+    assert.strictEqual(pendingBefore.length, 0);
+
+    await wdb.addBlock(block, [cbTX.toTX(), normalTX.toTX()]);
+
+    const balanceBefore = await wallet.getBalance();
+
+    assert.strictEqual(balanceBefore.confirmed, balanceBefore.unconfirmed);
+    assert.strictEqual(balanceBefore.confirmed, 10000);
+    assert.strictEqual(balanceBefore.tx, 2);
+    assert.strictEqual(balanceBefore.coin, 2);
+
+    await wdb.removeBlock(block, [cbTX.toTX(), normalTX.toTX()]);
+    const pending = await wallet.getPending();
+
+    assert.strictEqual(pending.length, 1);
+
+    const balance = await wallet.getBalance();
+
+    assert.strictEqual(balance.confirmed, 0);
+    assert.strictEqual(balance.unconfirmed, 5000);
+    assert.strictEqual(balance.tx, 1);
+    assert.strictEqual(balance.coin, 1);
+  });
+
   it('should handle double-spend (not our input)', async () => {
     const wallet = await wdb.create();